Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[
perflint
] Addperflint
plugin, add first rulePERF102
#4821[
perflint
] Addperflint
plugin, add first rulePERF102
#4821Changes from 14 commits
3dd98eb
60ecf26
b0312fe
db992b7
00a0f8d
99b6fb7
1c8655e
060eb69
c89268e
c50734e
b8b6cda
9dab688
f9c2448
103012b
5d8b92b
0419305
f68b4f8
bc71abf
50be231
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the prefix here as we would want a 3 letter abbreviation for the plugin name (
PER
,PRF
?). It's ok to deviate from the actual rule code for consistency :)\cc @charliermarsh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
PERF
? We've started to use some four-letter prefixes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could convert this into a function which can accept a
subset
parameter which could be anenum
instead of a string and anexpr
parameter which would be the other expression node.We could also simplify the extraction of
fix_val
to avoid creating an invalid state where the other element isn't aName
orTuple
node.