Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the flake8-quotes plugin #495

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Implement the flake8-quotes plugin #495

merged 1 commit into from
Oct 28, 2022

Conversation

charliermarsh
Copy link
Member

No description provided.

@charliermarsh charliermarsh force-pushed the charlie/flake8-quotes branch 5 times, most recently from 6877a85 to 4946634 Compare October 28, 2022 21:51
@charliermarsh charliermarsh merged commit 86265c1 into main Oct 28, 2022
@charliermarsh charliermarsh deleted the charlie/flake8-quotes branch October 28, 2022 21:52
samuelcolvin
samuelcolvin reviewed Nov 2, 2022
View reviewed changes
Copy link

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thanks so much.

I'm just trying to use ruff on pydantic, I'll tag you in a PR soon.

src/settings.rs
@@ -133,6 +135,7 @@ impl RawSettings {
quiet: bool,
) -> Result<Self> {
let config = load_config(pyproject, quiet)?;
println!("{:?}", config.flake8_quotes);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelcolvin samuelcolvin samuelcolvin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@charliermarsh @samuelcolvin