Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure release tagging has access to repo clone #5240

Merged
merged 1 commit into from Jun 21, 2023
Merged

Conversation

charliermarsh
Copy link
Member

Summary

The release failed, but late enough that I was able to do the remaining steps manually. The issue here is that the tagging step requires that we clone the repo. I split the upload (to PyPI), tagging (in Git), and publishing (to GitHub Releases) phases into their own steps, since they need different resources + permissions anyway.

@charliermarsh charliermarsh added the release Related to the release process label Jun 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.01      6.9±0.02ms     5.9 MB/sec    1.00      6.9±0.02ms     5.9 MB/sec
formatter/numpy/ctypeslib.py               1.01   1382.0±4.45µs    12.0 MB/sec    1.00   1374.4±4.64µs    12.1 MB/sec
formatter/numpy/globals.py                 1.00    133.4±0.28µs    22.1 MB/sec    1.00    133.4±1.01µs    22.1 MB/sec
formatter/pydantic/types.py                1.01      2.8±0.01ms     9.1 MB/sec    1.00      2.8±0.03ms     9.2 MB/sec
linter/all-rules/large/dataset.py          1.00     13.7±0.11ms     3.0 MB/sec    1.02     14.0±0.08ms     2.9 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.5±0.01ms     4.8 MB/sec    1.01      3.5±0.01ms     4.8 MB/sec
linter/all-rules/numpy/globals.py          1.00    362.7±0.95µs     8.1 MB/sec    1.00    362.2±2.29µs     8.1 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.1±0.05ms     4.2 MB/sec    1.01      6.1±0.03ms     4.2 MB/sec
linter/default-rules/large/dataset.py      1.01      7.1±0.02ms     5.7 MB/sec    1.00      7.0±0.02ms     5.8 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1470.4±2.56µs    11.3 MB/sec    1.00   1470.5±3.12µs    11.3 MB/sec
linter/default-rules/numpy/globals.py      1.00    155.3±0.26µs    19.0 MB/sec    1.00    155.9±0.20µs    18.9 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.2±0.01ms     8.0 MB/sec    1.00      3.2±0.00ms     8.0 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.17      8.8±0.08ms     4.6 MB/sec    1.00      7.5±0.05ms     5.4 MB/sec
formatter/numpy/ctypeslib.py               1.13  1749.4±30.95µs     9.5 MB/sec    1.00  1545.8±49.22µs    10.8 MB/sec
formatter/numpy/globals.py                 1.09    168.1±3.96µs    17.6 MB/sec    1.00    153.9±5.03µs    19.2 MB/sec
formatter/pydantic/types.py                1.15      3.6±0.04ms     7.2 MB/sec    1.00      3.1±0.04ms     8.2 MB/sec
linter/all-rules/large/dataset.py          1.00     14.9±0.17ms     2.7 MB/sec    1.00     15.0±0.12ms     2.7 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.0±0.04ms     4.2 MB/sec    1.00      4.0±0.05ms     4.2 MB/sec
linter/all-rules/numpy/globals.py          1.01    485.2±7.44µs     6.1 MB/sec    1.00    481.9±6.26µs     6.1 MB/sec
linter/all-rules/pydantic/types.py         1.01      6.7±0.06ms     3.8 MB/sec    1.00      6.7±0.05ms     3.8 MB/sec
linter/default-rules/large/dataset.py      1.00      7.8±0.04ms     5.2 MB/sec    1.00      7.8±0.05ms     5.2 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1667.1±14.31µs    10.0 MB/sec    1.00  1660.8±16.17µs    10.0 MB/sec
linter/default-rules/numpy/globals.py      1.01    192.9±2.83µs    15.3 MB/sec    1.00    190.9±3.31µs    15.5 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.5±0.03ms     7.2 MB/sec    1.00      3.5±0.03ms     7.2 MB/sec

@charliermarsh charliermarsh merged commit 4634560 into main Jun 21, 2023
16 checks passed
@charliermarsh charliermarsh deleted the charlie/tag branch June 21, 2023 14:24
- name: "Publish to GitHub"
uses: softprops/action-gh-release@v1
with:
draft: true
draft: false
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, this should be true.

charliermarsh added a commit that referenced this pull request Jun 22, 2023
I accidentally changed `draft: false` to `draft: true` in #5240. I
actually think Copilot did this without me realizing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Related to the release process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants