Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary check_deferred_assignments #5963

Merged
merged 1 commit into from
Jul 22, 2023
Merged

Conversation

charliermarsh
Copy link
Member

Summary

These rules can just be included in the check_deferred_scopes.

@charliermarsh charliermarsh marked this pull request as ready for review July 22, 2023 01:50
|
= help: Remove assignment to unused variable `x`
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This is just a tiebreaker, i.e., the diagnostics are reordered.)

@charliermarsh charliermarsh force-pushed the charlie/visit branch 2 times, most recently from c38d908 to 049c9c0 Compare July 22, 2023 01:59
@charliermarsh charliermarsh enabled auto-merge (squash) July 22, 2023 01:59
@charliermarsh charliermarsh merged commit 2dcd9e2 into main Jul 22, 2023
16 checks passed
@charliermarsh charliermarsh deleted the charlie/visit branch July 22, 2023 02:08
@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.01      9.4±0.17ms     4.3 MB/sec    1.00      9.3±0.03ms     4.4 MB/sec
formatter/numpy/ctypeslib.py               1.00   1848.3±8.09µs     9.0 MB/sec    1.00  1843.9±12.80µs     9.0 MB/sec
formatter/numpy/globals.py                 1.00    201.5±2.26µs    14.6 MB/sec    1.00    201.6±1.91µs    14.6 MB/sec
formatter/pydantic/types.py                1.00      4.0±0.02ms     6.4 MB/sec    1.00      4.0±0.01ms     6.4 MB/sec
linter/all-rules/large/dataset.py          1.00     13.1±0.16ms     3.1 MB/sec    1.00     13.0±0.08ms     3.1 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      3.3±0.01ms     5.0 MB/sec    1.00      3.3±0.01ms     5.0 MB/sec
linter/all-rules/numpy/globals.py          1.00    435.4±1.14µs     6.8 MB/sec    1.00    437.3±1.72µs     6.7 MB/sec
linter/all-rules/pydantic/types.py         1.00      5.9±0.03ms     4.3 MB/sec    1.00      5.9±0.03ms     4.3 MB/sec
linter/default-rules/large/dataset.py      1.00      6.6±0.03ms     6.2 MB/sec    1.01      6.6±0.04ms     6.1 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00   1417.4±3.21µs    11.7 MB/sec    1.01   1427.5±1.51µs    11.7 MB/sec
linter/default-rules/numpy/globals.py      1.00    159.9±0.27µs    18.5 MB/sec    1.00    160.4±1.00µs    18.4 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.0±0.01ms     8.5 MB/sec    1.00      3.0±0.01ms     8.5 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
formatter/large/dataset.py                 1.00     11.1±0.08ms     3.7 MB/sec    1.01     11.2±0.06ms     3.6 MB/sec
formatter/numpy/ctypeslib.py               1.00      2.1±0.02ms     7.8 MB/sec    1.02      2.2±0.02ms     7.7 MB/sec
formatter/numpy/globals.py                 1.00    231.7±2.72µs    12.7 MB/sec    1.01    235.0±5.07µs    12.6 MB/sec
formatter/pydantic/types.py                1.00      4.7±0.02ms     5.4 MB/sec    1.02      4.8±0.04ms     5.3 MB/sec
linter/all-rules/large/dataset.py          1.00     15.4±0.10ms     2.6 MB/sec    1.02     15.8±0.09ms     2.6 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.1±0.05ms     4.1 MB/sec    1.02      4.2±0.04ms     4.0 MB/sec
linter/all-rules/numpy/globals.py          1.00   425.2±10.14µs     6.9 MB/sec    1.03    439.8±6.47µs     6.7 MB/sec
linter/all-rules/pydantic/types.py         1.00      7.1±0.06ms     3.6 MB/sec    1.04      7.3±0.07ms     3.5 MB/sec
linter/default-rules/large/dataset.py      1.00      8.2±0.04ms     5.0 MB/sec    1.02      8.3±0.04ms     4.9 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1659.6±16.19µs    10.0 MB/sec    1.02  1689.0±13.05µs     9.9 MB/sec
linter/default-rules/numpy/globals.py      1.00    175.9±1.50µs    16.8 MB/sec    1.01    177.4±2.98µs    16.6 MB/sec
linter/default-rules/pydantic/types.py     1.00      3.7±0.03ms     6.9 MB/sec    1.01      3.7±0.02ms     6.9 MB/sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant