Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement B009 #669

Merged
merged 4 commits into from
Nov 10, 2022
Merged

Implement B009 #669

merged 4 commits into from
Nov 10, 2022

Conversation

harupy
Copy link
Contributor

@harupy harupy commented Nov 10, 2022

charliermarsh
charliermarsh reviewed Nov 10, 2022
View reviewed changes
src/flake8_bugbear/plugins/getattr_with_constant.rs Outdated
use crate::check_ast::Checker;
use crate::checks::{Check, CheckKind};

const KWLIST: [&str; 35] = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a link to the source for this list?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got it :)

@charliermarsh charliermarsh merged commit 1888f6d into astral-sh:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@harupy @charliermarsh