Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for Notebook text output #7925

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Add test for Notebook text output #7925

merged 2 commits into from
Oct 13, 2023

Conversation

dhruvmanila
Copy link
Member

Summary

This PR adds test cases for the Notebook output in text format.

Test Plan

Update test snapshots.

@dhruvmanila dhruvmanila mentioned this pull request Oct 12, 2023
Merged
3 tasks
@dhruvmanila
Copy link
Member Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@dhruvmanila dhruvmanila mentioned this pull request Oct 12, 2023
Merged
@dhruvmanila dhruvmanila added the internal An internal refactor or improvement label Oct 12, 2023
@github-actions
Copy link
Contributor

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Base automatically changed from dhruv/notebook-one-indexed to main October 13, 2023 00:53
@dhruvmanila dhruvmanila merged commit f08a5f6 into main Oct 13, 2023
16 checks passed
@dhruvmanila dhruvmanila deleted the dhruv/notebook-output-test branch October 13, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh approved these changes

Assignees
No one assigned
Labels
internal An internal refactor or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhruvmanila @charliermarsh