Treat type aliases as typing-only expressions #7968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Check ResultsEcosystem✅ ecosystem check detected no changes. |
This was referenced Oct 17, 2023
charliermarsh
added a commit
that referenced
this pull request
Oct 18, 2023
<!-- Thank you for contributing to Ruff! To help us out with reviewing, please consider the following: - Does this pull request include a summary of the change? (See below.) - Does this pull request include a descriptive title? - Does this pull request include references to any relevant issues? --> ## Summary In #7968, I introduced a regression whereby we started to treat imports used _only_ in type annotation bounds (with `__future__` annotations) as unused. The root of the issue is that I started using `visit_annotation` for these bounds. So we'd queue up the bound in the list of deferred type parameters, then when visiting, we'd further queue it up in the list of deferred type annotations... Which we'd then never visit, since deferred type annotations are visited _before_ deferred type parameters. Anyway, the better solution here is to use a dedicated flag for these, since they have slightly different behavior than type annotations. I've also fixed what I _think_ is a bug whereby we previously failed to resolve `Callable` in: ```python type RecordCallback[R: Record] = Callable[[R], None] from collections.abc import Callable ``` IIUC, the values in type aliases should be evaluated lazily, like type parameters. Closes #8017. ## Test Plan `cargo test`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Given
type RecordOrThings = Record | int | str, the right-hand side won't be evaluated at runtime. Same goes forRecordintype RecordCallback[R: Record] = Callable[[R], None]. This PR modifies the visitation logic to treat them as typing-only.Closes #7966.