Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid including literal shell=True for truthy, non-True diagnostics #8359

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

charliermarsh
Copy link
Member

Summary

If the value of shell wasn't literally True, we now show a message describing it as truthy, rather than the (misleading) shell=True literal in the diagnostic.

Closes #8310.

@charliermarsh charliermarsh added the bug Something isn't working label Oct 30, 2023
@charliermarsh charliermarsh changed the title Use clearer truthiness message when reporting shell=True diagnostics Avoid including literal shell=True for truthy, non-True diagnostics Oct 30, 2023
@charliermarsh charliermarsh enabled auto-merge (squash) October 30, 2023 15:43
@charliermarsh charliermarsh merged commit 161c093 into main Oct 30, 2023
16 checks passed
@charliermarsh charliermarsh deleted the charlie/shell branch October 30, 2023 15:44
@github-actions
Copy link
Contributor

PR Check Results

Ecosystem

✅ ecosystem check detected no linter changes.

✅ ecosystem check detected no format changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S604 shows warning for any type, not just True
2 participants