Fix ordering for force-sort-within-sections
#8665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imports like `from x import y as z` don't have an "asname" for the module, so they were placed before imports like `import x as w` since `None` < `Some(s)` for any string s. The fix is to first sort by `first_alias` since it's `None` for `import x as w`.
|
|
I really appreciate the quick investigation and turnaround here @bluthej. |
|
Well the regression was due to my refactor so that was the least I could do 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8661
Summary
Imports like
from x import ydon't have an "asname" for the module, so they were placed before imports likeimport x as wsinceNone<Some(s)for any string s.The fix is to first sort by
first_alias, since it'sNoneforimport x as w, and then byasname.Test Plan
I included the example from the issue to avoid future regressions.