Treat display as a builtin in IPython #8707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Nov 15, 2023
| @@ -54,7 +55,7 @@ pub(crate) struct TestedNotebook { | |||
| } | |||
|
|
|||
| #[cfg(not(fuzzing))] | |||
| pub(crate) fn test_notebook_path( | |||
| pub(crate) fn assert_notebook_path( | |||
There was a problem hiding this comment.
I renamed this to avoid some confusion.
|
dhruvmanila
approved these changes
Nov 16, 2023
Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
konstin
added a commit
that referenced
this pull request
Nov 16, 2023
I checked for ipython-specific builtins on python 3.11 using ```python import json from subprocess import check_output builtins_python = json.loads(check_output(["python3", "-c" "import json; print(json.dumps(dir(__builtins__)))"])) builtins_ipython = json.loads(check_output(["ipython3", "-c" "import json; print(json.dumps(dir(__builtins__)))"])) print(sorted(set(builtins_ipython) - set(builtins_python))) ``` and updated the relevant constant and match. The list changes from `display` to `__IPYTHON__`, `display`, `get_ipython`. Followup to #8707
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
displayis a special-cased builtin in IPython. This PR adds it to the builtin namespace when analyzing IPython notebooks.Closes #8702.