Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pycodestyle] Add blank line(s) rules (E301, E302, E303, E304, E305, E306) #8720

Closed
wants to merge 52 commits into from
Closed

[pycodestyle] Add blank line(s) rules (E301, E302, E303, E304, E305, E306) #8720

wants to merge 52 commits into from

Commits on Nov 9, 2023

  1. Add V1 version.

    @hoel-bagard
    hoel-bagard committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    32ec9e7 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Keep track of previous streak of blank lines to fix 301.

    @hoel-bagard
    hoel-bagard committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    624c7a5 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2023

  1. Fix 302.

    @hoel-bagard
    hoel-bagard committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    cd02e11 View commit details
    Browse the repository at this point in the history

  2. Fix 305.

    @hoel-bagard
    hoel-bagard committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    f9a19ef View commit details
    Browse the repository at this point in the history

  3. Fix 306.

    @hoel-bagard
    hoel-bagard committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    a10bea3 View commit details
    Browse the repository at this point in the history

  4. Fix 303 regression.

    @hoel-bagard
    hoel-bagard committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    f57b614 View commit details
    Browse the repository at this point in the history

  5. Add snapshots.

    @hoel-bagard
    hoel-bagard committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    42c6f12 View commit details
    Browse the repository at this point in the history

  6. Update nursery rules list

    @hoel-bagard
    hoel-bagard committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    2283019 View commit details
    Browse the repository at this point in the history

  7. Add a non-error test and its corresponding fix.

    @hoel-bagard
    hoel-bagard committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    06618c2 View commit details
    Browse the repository at this point in the history

  8. Add a TODO comment.

    @hoel-bagard
    hoel-bagard committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    09b6ba1 View commit details
    Browse the repository at this point in the history

  9. Update snapshots following 06618c2.

    @hoel-bagard
    hoel-bagard committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    1bdd181 View commit details
    Browse the repository at this point in the history

  10. Clippy fixes.

    @hoel-bagard
    hoel-bagard committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    2a7b4cb View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Store line.is_comment_only()'s result in a variable. Use config more.

    @hoel-bagard
    hoel-bagard committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    aa7b6e6 View commit details
    Browse the repository at this point in the history

  2. Do not ignore first logical line when it comes to tracked vars.

    @hoel-bagard
    hoel-bagard committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    8d3744d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'astral-sh:main' into add_blank_lines_E30_V2

    @hoel-bagard
    hoel-bagard committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    d670100 View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary check.

    @hoel-bagard
    hoel-bagard committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    bd282ec View commit details
    Browse the repository at this point in the history

  5. Update snapshots (Fix -> Safe fix)

    @hoel-bagard
    hoel-bagard committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    2ef4d02 View commit details
    Browse the repository at this point in the history

  6. Fix first logical line issue.

    @hoel-bagard
    hoel-bagard committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    36d2547 View commit details
    Browse the repository at this point in the history

  7. Fix false positive caused by a class's docstring.

    @hoel-bagard
    hoel-bagard committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    0f61011 View commit details
    Browse the repository at this point in the history

  8. Only trigger E302 on non-indented classes/functions.

    @hoel-bagard
    hoel-bagard committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    0e9ca4e View commit details
    Browse the repository at this point in the history

  9. Fix decorator linked false positive. 

    decorator -> comment -> decorator was causing a false positive.
    @hoel-bagard
    hoel-bagard committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    3f6f207 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Fix E301 false positive. 

    Fix false positive where a method following an if (or other indentation
inducing keyword) would trigger E301.
    @hoel-bagard
    hoel-bagard committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    b667c5c View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2023

  1. Fix decorator + async false positive. 

    This also move the trigger on an async def from the def to the async.
    @hoel-bagard
    hoel-bagard committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    0bf4c45 View commit details
    Browse the repository at this point in the history

  2. Fix E302 error message.

    @hoel-bagard
    hoel-bagard committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    7de1e05 View commit details
    Browse the repository at this point in the history

  3. Improve E302's fix interaction with comments. 

    Make the comment stick to the following line instead of the preceding
one.
    @hoel-bagard
    hoel-bagard committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    0c1450a View commit details
    Browse the repository at this point in the history

  4. Fix E301 regression and improve E301 fix.

    @hoel-bagard
    hoel-bagard committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    7b9b277 View commit details
    Browse the repository at this point in the history

  5. Fix E302 fix's interaction with comments.

    @hoel-bagard
    hoel-bagard committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    1d7b235 View commit details
    Browse the repository at this point in the history

  6. Clippy fix.

    @hoel-bagard
    hoel-bagard committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    73e5ba9 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2023

  1. Fix docstring + comment leading to false positive.

    @hoel-bagard
    hoel-bagard committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    c1a7a7c View commit details
    Browse the repository at this point in the history

  2. Fix E305 false positive for indented classes/defs

    @hoel-bagard
    hoel-bagard committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    b484ca4 View commit details
    Browse the repository at this point in the history

  3. Make rules independent. 

    This will slow down things a bit, but makes it clearer what the
conditions for a given rule to trigger are.
    @hoel-bagard
    hoel-bagard committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    6d0fbf2 View commit details
    Browse the repository at this point in the history

  4. Fix typo.

    @hoel-bagard
    hoel-bagard committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    f7b2f89 View commit details
    Browse the repository at this point in the history

  5. Rule simplification. 

    Also fix a E306 regression.
    @hoel-bagard
    hoel-bagard committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    5365830 View commit details
    Browse the repository at this point in the history

  6. Fix E306 false negative when using async or decorator.

    @hoel-bagard
    hoel-bagard committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    bafddf9 View commit details
    Browse the repository at this point in the history

  7. Simplify/fix E301's condition.

    @hoel-bagard
    hoel-bagard committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    ea9d9c8 View commit details
    Browse the repository at this point in the history

  8. Make if condition more readable.

    @hoel-bagard
    hoel-bagard committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    4d2f7b5 View commit details
    Browse the repository at this point in the history

  9. Simplify E301's if condition.

    @hoel-bagard
    hoel-bagard committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    0867011 View commit details
    Browse the repository at this point in the history

  10. Remove unnecessary clone.

    @hoel-bagard
    hoel-bagard committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    9f2d339 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'astral-sh:main' into add_blank_lines_E30_V2

    @hoel-bagard
    hoel-bagard committed Nov 19, 2023
    Configuration menu
    Copy the full SHA
    46b0c46 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Modify E303 to use top-levelness instead of class/def.

    @hoel-bagard
    hoel-bagard committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    3eb5c62 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary clone derive.

    @hoel-bagard
    hoel-bagard committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    9b15d8c View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. Update E306 

    cf PyCQA/pycodestyle#1216
    @hoel-bagard
    hoel-bagard committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    fd65c70 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. is_first_logical_line -> is_not_first_logical_line to be able to deri… 

    …ve Default.
    @hoel-bagard
    hoel-bagard committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    883818b View commit details
    Browse the repository at this point in the history

  2. Remove BlankLinesConfig struct and use module level constants instead.

    @hoel-bagard
    hoel-bagard committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    29f0e6b View commit details
    Browse the repository at this point in the history

  3. Use an enum to keep track of class and fn status.

    @hoel-bagard
    hoel-bagard committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    0b6bfdf View commit details
    Browse the repository at this point in the history

  4. Remove for loop, clippy fixes.

    @hoel-bagard
    hoel-bagard committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    304115a View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary Option from is_docstring.

    @hoel-bagard
    hoel-bagard committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    083f4f5 View commit details
    Browse the repository at this point in the history

  6. Use an enum to keep track of what the line is following.

    @hoel-bagard
    hoel-bagard committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    60311c3 View commit details
    Browse the repository at this point in the history

  7. Update crates/ruff_linter/src/rules/pycodestyle/rules/logical_lines/b… 

    …lank_lines.rs

Co-authored-by: Micha Reiser <micha@reiser.io>
    @hoel-bagard @MichaReiser
    hoel-bagard and MichaReiser committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    dc2fe49 View commit details
    Browse the repository at this point in the history

  8. BlankLinesTrackingVars -> BlankLinesChecker 

    With BlankLinesChecker containing the method doing the checking.
    @hoel-bagard
    hoel-bagard committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    727a17b View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2023

  1. Add test case

    @hoel-bagard
    hoel-bagard committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    cbb6c1b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'astral-sh:main' into add_blank_lines_E30_V2

    @hoel-bagard
    hoel-bagard committed Dec 16, 2023
    Configuration menu
    Copy the full SHA
    29849d5 View commit details
    Browse the repository at this point in the history