Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document link between import sorting and formatter #9117

Conversation

bluthej
Copy link
Contributor

@bluthej bluthej commented Dec 13, 2023

Fixes #8367.

This documents the link between import sorting and the formatter to clear up some existing confusion. This can probably be removed once #8232 gets merged.

@MichaReiser MichaReiser added the documentation Improvements or additions to documentation label Dec 14, 2023
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. That could indeed help to reduce some of the confusion.

ruff format .
```

A unified command for both linting and formatting is currently [being developed](https://github.com/astral-sh/ruff/issues/8232).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not actively working on it just yet (we hopefully get to it at the beginning of next year). I'm not sure if it matters or if we should change the sentence to *linting and formatting is planned.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rephrased that part accordingly, what do you think?

@MichaReiser MichaReiser merged commit db38078 into astral-sh:main Dec 15, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve documentation on import sorting
2 participants