Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --extension support to the formatter #9483

Merged
merged 1 commit into from Jan 12, 2024
Merged

Add --extension support to the formatter #9483

merged 1 commit into from Jan 12, 2024

Conversation

charliermarsh
Copy link
Member

Summary

We added --extension to ruff check, but it's equally applicable to ruff format.

Closes #9482.

Resolves #9481.

Test Plan

cargo test

@charliermarsh charliermarsh marked this pull request as ready for review January 12, 2024 01:12
@charliermarsh charliermarsh added the cli Related to the command-line interface label Jan 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 12, 2024 •
edited

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

MichaReiser
MichaReiser approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I recommend removing the hidden from the CLI argument. We should not add it if we don't feel confident about supporting it.

crates/ruff_cli/src/args.rs Outdated Show resolved Hide resolved
crates/ruff_cli/src/args.rs Outdated Show resolved Hide resolved
@charliermarsh charliermarsh enabled auto-merge (squash) January 12, 2024 18:14
@charliermarsh charliermarsh merged commit 3261d16 into main Jan 12, 2024
16 checks passed
@charliermarsh charliermarsh deleted the charlie/ext branch January 12, 2024 18:53
@branchvincent branchvincent mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

@zanieb zanieb Awaiting requested review from zanieb

Assignees
No one assigned
Labels
cli Related to the command-line interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add --extension support to formatter CLI
2 participants
@charliermarsh @MichaReiser