Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing docs to use cargo bench -p ruff_benchmark #9535

Merged
merged 1 commit into from Jan 15, 2024

Conversation

charliermarsh
Copy link
Member

Summary

I found that cargo benchmark lexer didn't work as expected:

❯ cargo benchmark lexer
    Finished bench [optimized] target(s) in 0.08s
     Running benches/formatter.rs (target/release/deps/formatter-4e1d9bf9d3ba529d)
     Running benches/linter.rs (target/release/deps/linter-e449086ddfd8ad8c)

Turns out that cargo bench -p ruff_benchmark is now recommended over cargo benchmark, so updating the docs to reflect that.

@charliermarsh charliermarsh added the documentation Improvements or additions to documentation label Jan 15, 2024
@charliermarsh charliermarsh merged commit b983ab1 into main Jan 15, 2024
16 checks passed
@charliermarsh charliermarsh deleted the charlie/bench-docs branch January 15, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants