Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow arbitrary configuration options to be overridden via the CLI #9599

Merged
merged 61 commits into from
Feb 9, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
d73a453
WIP
AlexWaygood Jan 19, 2024
159fada
Get it working with `--isolated`
AlexWaygood Jan 19, 2024
7cd900c
Get it working without `--isolated`
AlexWaygood Jan 21, 2024
3cdbec7
i can spell
AlexWaygood Jan 21, 2024
0f2cc2c
Fix a couple build/test failures
AlexWaygood Jan 21, 2024
18daf07
Simplify `Configuration.transform()`
AlexWaygood Jan 22, 2024
721653d
Remove unnecessary special casing
AlexWaygood Jan 22, 2024
7bb72f5
Just pass a `Vec` to `from_cli_options`
AlexWaygood Jan 22, 2024
e7a1d89
Misc review comments
AlexWaygood Jan 23, 2024
7c05cd5
More docs cleanup
AlexWaygood Jan 23, 2024
26b7dc8
use an `Arc`
AlexWaygood Jan 23, 2024
59e6e0a
Use `clap` a little more for slightly prettier errors
AlexWaygood Jan 23, 2024
f33e91e
Merge branch 'main' into arbitrary-cli-overrides
AlexWaygood Jan 24, 2024
cd6b4ce
regen docs
AlexWaygood Jan 24, 2024
3fb5d21
Improve error messages
AlexWaygood Jan 25, 2024
2568265
Improve error messages more
AlexWaygood Jan 25, 2024
d6a18fe
Merge branch 'main' into arbitrary-cli-overrides
AlexWaygood Jan 25, 2024
8379890
Add tests for some failure cases
AlexWaygood Jan 25, 2024
366cd1b
Also test the formatter
AlexWaygood Jan 25, 2024
2583136
Many more tests
AlexWaygood Jan 25, 2024
981210c
spelling
AlexWaygood Jan 25, 2024
3bfcae2
Simplify some code
AlexWaygood Jan 25, 2024
e32dd0a
Further improve error messages
AlexWaygood Jan 26, 2024
aca4af5
cargo fmt
AlexWaygood Jan 26, 2024
446517b
couple more tests
AlexWaygood Jan 26, 2024
c39fbd6
Docs
AlexWaygood Jan 26, 2024
ebd7286
Apply suggestions from code review
AlexWaygood Jan 29, 2024
d771243
add a newline
AlexWaygood Jan 29, 2024
be48c4f
Fix compile; address more Micha comments
AlexWaygood Jan 29, 2024
8f79c65
Couple more comments
AlexWaygood Jan 29, 2024
1cc613c
Return `&Path` from `config_file()`
AlexWaygood Jan 29, 2024
c12bb11
Improve docs for `--config`
AlexWaygood Jan 29, 2024
a880691
regen docs
AlexWaygood Jan 29, 2024
59e07c3
Delete `Configuration::transform()`
AlexWaygood Jan 29, 2024
7ec9e8a
Rename the enum and its variants
AlexWaygood Jan 29, 2024
de846ba
More consistent naming for arguments that take instances of `ConfigAr…
AlexWaygood Jan 29, 2024
893f214
Better dev docs for the `ConfigArguments` struct
AlexWaygood Jan 29, 2024
0ccc608
Rework docs; improve test
AlexWaygood Jan 29, 2024
b12a9c7
cargo fmt
AlexWaygood Jan 29, 2024
1501eeb
Don't return `clap::Error` after the initial argument-parsing phase
AlexWaygood Jan 29, 2024
e46c06a
Various cleanups
AlexWaygood Feb 1, 2024
e39aa39
Merge branch 'main' into arbitrary-cli-overrides
AlexWaygood Feb 1, 2024
e1a3328
Merge branch 'main' into arbitrary-cli-overrides
AlexWaygood Feb 1, 2024
d83cfa5
Fixup some issues after merging in `main`
AlexWaygood Feb 1, 2024
138c6c3
Fix remaining test failures
AlexWaygood Feb 1, 2024
e500b39
Merge branch 'main' into arbitrary-cli-overrides
AlexWaygood Feb 1, 2024
acca909
Merge branch 'main' into arbitrary-cli-overrides
AlexWaygood Feb 6, 2024
5e83ef8
Fixup after merge
AlexWaygood Feb 6, 2024
18da11b
Merge branch 'arbitrary-cli-overrides' of https://github.com/AlexWayg…
AlexWaygood Feb 6, 2024
0b0917b
``
AlexWaygood Feb 6, 2024
5074bff
Address some Zanie comments
AlexWaygood Feb 6, 2024
c6019f7
Merge branch 'arbitrary-cli-overrides' of https://github.com/AlexWayg…
AlexWaygood Feb 6, 2024
7d6f9dd
Add a test for overriding a deprecated CLI option via the CLI
AlexWaygood Feb 6, 2024
bb2e6ee
regen docs
AlexWaygood Feb 6, 2024
7739440
Use `insta-filters` for the tests where the tempdir path is included …
AlexWaygood Feb 7, 2024
88e7273
Multiline tips instead of multiple tips
AlexWaygood Feb 7, 2024
bccab4e
Make more concise
AlexWaygood Feb 7, 2024
6eea797
Differentiate between TOML syntax errors and valid TOML that we don't…
AlexWaygood Feb 7, 2024
983e5aa
Address Charlie's docs review
AlexWaygood Feb 9, 2024
789d1d0
Add a transitional sentence
AlexWaygood Feb 9, 2024
0f8a583
Merge branch 'main' into arbitrary-cli-overrides
AlexWaygood Feb 9, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions crates/ruff/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ serde_json = { workspace = true }
shellexpand = { workspace = true }
strum = { workspace = true, features = [] }
thiserror = { workspace = true }
toml = { workspace = true }
tracing = { workspace = true, features = ["log"] }
walkdir = { workspace = true }
wild = { workspace = true }
Expand Down
Loading
Loading