feat(workflow): version and tag update #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in #5, `uv` does not use `v` in its version tagging. Considering that this repo is primarily a mirror of the `uv` repo, it should match.
Although this functionality is not required, some users might be confused if the tag and release version are not the same. This in reference to #4 Additionally, the body of the release points to the uv release
zanieb
reviewed
Mar 23, 2024
zanieb
reviewed
Mar 23, 2024
In relation to : #6 (comment) Although not strictly necessary, it is good to follow "best practices." A release tag should only contain `\d+\.\d+\.\d+.*`
This was referenced Mar 23, 2024
charliermarsh
pushed a commit
to astral-sh/ruff-pre-commit
that referenced
this pull request
Mar 30, 2024
## Summary Add a GitHub workflow for creating a new release, automatically, when a new tag is created. This solves #78. The code is very similar to the changes added in astral-sh/uv-pre-commit#6 The primary difference, is that the URL points to ruff and this one checks for if the tag starts with a `v`, but it is optional. This lets you change ruff versions to not have a `v` in the future. Although the `mirror.py` will need to be updated. Speaking of updates to `mirror.py`, I ran `ruff` on it and updated the `subprocess` to raise an error on failure. ## Test Plan Locally tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(mirror): remove
vfrom versionAs mentioned in #5,
uvdoes not usevin its version tagging. Considering that this repo is primarily a mirror of theuvrepo, it should match.feat(workflow): auto release on tag creation
Although this functionality is not required, some users might be confused if the tag and release version are not the same. This in reference to #4
Additionally, the body of the release points to the uv release