Skip to content

Commit

Permalink
Fix wheel builds and uploads for musl ARM (#2518)
Browse files Browse the repository at this point in the history
If you look at https://pypi.org/project/uv/0.1.22/#files...

- We didn't upload the ARMv6 wheel (I thought I had removed the `# Skip
for `arm`, which is not supported by PyPI.`), it must've gotten re-added
in a rebase or something.
- We lost the musllinux builds for ARM. I think this is because I built
them as manylinux.
  • Loading branch information
charliermarsh committed Mar 18, 2024
1 parent 9afb360 commit 2c98154
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/build-binaries.yml
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,6 @@ jobs:
maturin_docker_options: -e JEMALLOC_SYS_WITH_LG_PAGE=16
- target: armv7-unknown-linux-gnueabihf
arch: armv7
- target: armv7-unknown-linux-musleabihf
arch: armv7
- target: arm-unknown-linux-musleabihf
arch: arm

Expand Down Expand Up @@ -306,8 +304,6 @@ jobs:
pip3 install ${{ env.PACKAGE_NAME }} --no-index --find-links dist/ --force-reinstall
${{ env.MODULE_NAME }} --help
- name: "Upload wheels"
# Skip for `arm`, which is not supported by PyPI.
if: ${{ matrix.platform.arch != 'arm' }}
uses: actions/upload-artifact@v4
with:
name: wheels-${{ matrix.platform.target }}
Expand Down Expand Up @@ -540,6 +536,8 @@ jobs:
- target: aarch64-unknown-linux-musl
arch: aarch64
maturin_docker_options: -e JEMALLOC_SYS_WITH_LG_PAGE=16
- target: armv7-unknown-linux-musleabihf
arch: armv7

steps:
- uses: actions/checkout@v4
Expand Down

0 comments on commit 2c98154

Please sign in to comment.