Use &impl AsRef<Path> instead of type parameter

astral-sh · Jun 18, 2024 · 67e5c61 · 67e5c61
1 parent 1ce2147
commit 67e5c61
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/crates/uv-toolchain/src/lib.rs b/crates/uv-toolchain/src/lib.rs
@@ -289,9 +289,9 @@ mod tests {
         }
 
         /// Create child directories in a temporary directory.
-        fn new_search_path_directories<P: AsRef<Path>>(
+        fn new_search_path_directories(
             &mut self,
-            names: &[P],
+            names: &[impl AsRef<Path>],
         ) -> Result<Vec<ChildPath>> {
             let paths = names
                 .iter()

diff --git a/crates/uv/src/shell.rs b/crates/uv/src/shell.rs
@@ -67,7 +67,7 @@ impl Shell {
     /// assert_eq!(Shell::from_shell_path("/usr/bin/zsh"), Some(Shell::Zsh));
     /// assert_eq!(Shell::from_shell_path("/opt/my_custom_shell"), None);
     /// ```
-    pub(crate) fn from_shell_path<P: AsRef<Path>>(path: P) -> Option<Shell> {
+    pub(crate) fn from_shell_path(path: impl AsRef<Path>) -> Option<Shell> {
         parse_shell_from_path(path.as_ref())
     }
 }

diff --git a/crates/uv/tests/common/mod.rs b/crates/uv/tests/common/mod.rs
@@ -582,7 +582,7 @@ pub fn site_packages_path(venv: &Path, python: &str) -> PathBuf {
     }
 }
 
-pub fn venv_bin_path<P: AsRef<Path>>(venv: &P) -> PathBuf {
+pub fn venv_bin_path(venv: impl AsRef<Path>) -> PathBuf {
     if cfg!(unix) {
         venv.as_ref().join("bin")
     } else if cfg!(windows) {