Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid assuming RECORD file is in platlib #2091

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Avoid assuming RECORD file is in platlib #2091

merged 1 commit into from
Feb 29, 2024

Conversation

charliermarsh
Copy link
Member

Summary

This was a missed find-and-replace. We shouldn't assume layout.platlib here, since RECORD will be written to site_packages (which could be layout.purelib).

This is hard to reproduce. You need a fresh environment where purelib and platlib differ (which isn't the case for virtualenvs, at least typically), and you need to be installing a new package that is a purelib. I tested it by manually changing platlib to point to a different path.

Closes #2064.

@charliermarsh charliermarsh added the bug Something isn't working label Feb 29, 2024
@charliermarsh charliermarsh marked this pull request as ready for review February 29, 2024 17:17
@charliermarsh charliermarsh enabled auto-merge (squash) February 29, 2024 17:20
@charliermarsh charliermarsh merged commit 6c23cff into main Feb 29, 2024
7 checks passed
@charliermarsh charliermarsh deleted the charlie/rec branch February 29, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install cobertura_clover_transform on first install
1 participant