Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): display warning message when trying to use an unsupported Python version #2757

Conversation

stegayet
Copy link
Contributor

@stegayet stegayet commented Apr 1, 2024

Summary

Closes #2587.

Test Plan

Locally tested.

@stegayet stegayet force-pushed the feat/add-warning-message-unsupported-python-version branch from b2e20d0 to bc0f7fe Compare April 1, 2024 17:01
@stegayet stegayet force-pushed the feat/add-warning-message-unsupported-python-version branch from bc0f7fe to 2a62dc1 Compare April 1, 2024 17:05
@henryiii henryiii mentioned this pull request Apr 2, 2024
@stegayet stegayet requested a review from zanieb April 4, 2024 15:28
@stegayet stegayet marked this pull request as ready for review April 4, 2024 15:28
@zanieb zanieb self-assigned this Apr 4, 2024
@zanieb
Copy link
Member

zanieb commented Apr 24, 2024

Thanks for the contributing! Sorry I took so long for a second review, I went to update this with main and realized we should probably move the warning into the uv-interpreter crate. See #3250

I've included you as a co-author still :)

@zanieb zanieb closed this in #3250 Apr 24, 2024
zanieb added a commit that referenced this pull request Apr 24, 2024
I rebased #2757 then realized that
we want to implement this for more than `uv venv`.

Closes #2587
Closes #2757

```
❯ cargo run -q -- pip install -p /Users/mz/bin/python3.7 anyio
warning: uv is only compatible with Python 3.8+, found Python 3.7.17.
Audited 1 package in 84ms

❯ cargo run -q -- venv -p /Users/mz/bin/python3.7
warning: uv is only compatible with Python 3.8+, found Python 3.7.17.
Using Python 3.7.17 interpreter at: /Users/mz/bin/python3.7
Creating virtualenv at: .venv
Activate with: source .venv/bin/activate
```

---------

Co-authored-by: Stevie Gayet <stegayet@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn when using uv with an incompatible Python version.
2 participants