Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for dependencies with no versions available #342

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Nov 6, 2023

Partially addresses #310
Addresses case at #309 (comment)
Follow-up to #300 ensuring PuffinExternal is used consistently when formatting messages

Example at https://github.com/astral-sh/puffin/pull/342/files#diff-5c74a74ef34ef1d6e7453de8d2d19134813156e8b6a657e6b5ed71fda5a3a870

@zanieb zanieb changed the title zanie/fix no version Improve error message for dependencies with no versions available Nov 6, 2023
depends on flask 3.0.0, root 0a0.dev0 is forbidden.
╰─▶ Because there is no version of werkzeug available matching >=3.0.0 and
flask 3.0.0 depends on werkzeug >=3.0.0, flask 3.0.0 is forbidden.
And because root depends on flask 3.0.0, root cannot be satisfied..
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can still do better here... per #310

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#344 is another step forward

@zanieb zanieb merged commit b0720ea into main Nov 6, 2023
3 checks passed
@zanieb zanieb deleted the zanie/fix-no-version branch November 6, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants