Use Metadata10 to parse PKG-INFO of legacy editable #3450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
force-pushed
the
uv-metadata10
branch
from
ebfed6f
to
60098f5
Compare
konstin
approved these changes
May 8, 2024
konstin
reviewed
May 8, 2024
|
|
||
| ----- stderr ----- | ||
| error: Failed to read metadata: from [SITE_PACKAGES]/paramiko.egg-link | ||
| Caused by: after parsing '0.1b0', found 'ulbasaur', which is not part of a valid version |
|
Thanks! LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out setuptools often uses Metadata-Version 2.1 in their PKG-INFO: https://github.com/hauntsaninja/setuptools/blob/4e766834d72623f3b938f1d4148547ea73af1bf5/setuptools/dist.py#L64
Metadata23requires Metadata-Version of at least 2.2.This means that uv doesn't actually recognise legacy editable installations from the most common way you'd actually get legacy editable installations (works great for most legacy editables I make at work though!)
Anyway, over here we only need the version and don't care about anything else. Rather than make a
Metadata21, I just add a version field toMetadata10. The one slightly tricky thing is that only Metadata-Version 1.2 and greater guarantee that the version number is PEP 440 compatible, so I store the version inMetadata10as aStringand only parse toVersionat time of use.Also did you know that back in 2004, paramiko had a pokemon based versioning system?