Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose inner marker_env #3786

Closed

Conversation

tdejager
Copy link
Contributor

Made the inner public, we used to be able to construct a MarkerEnvironment programatically. However, this functionality has seemed to be removed. As there is now public new method as far as I can see, we cannot use the with_* methods.

We are using this in https://github.com/prefix-dev/pixi/blob/main/src/pypi_marker_env.rs to construct an environment from locked data.

I could also create a new method instead, WDYT?

@konstin
Copy link
Member

konstin commented May 23, 2024

Would MarkerEnvironment::try_from(MarkerEnvironmentBuilder { ... }) work for you?

@tdejager
Copy link
Contributor Author

Seems to work! Totally missed that sorry!

@tdejager tdejager closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants