Implement a --verify-hashes hash-checking mode
#4007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@helderco -- what do you think of this behavior? I'm wondering if we should instead implement it such that if any hash is present, we enforce hashes (i.e., a setting that enables pip's default "implied hashes" behavior). |
charliermarsh
force-pushed
the
charlie/ver
branch
from
63cb22d
to
6e9ed7e
Compare
|
Yeah, requiring all hashes if any are present sgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is an alternative to
--require-hasheswhich will validate a hash if it's present, but ignore requirements that omit hashes or are absent from the lockfile entirely.So, e.g., transitive dependencies that are missing will not error; nor will dependencies that are included but lack a hash.
Closes #3305.