Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uv-resolver: add some tracing logs for when we filter requirements #4381

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

BurntSushi
Copy link
Member

Specifically, these are emitted when requirements fail to satisfy
Requires-Python or the markers associated with the current fork in the
resolver.

Closes #4373

Specifically, these are emitted when requirements fail to satisfy
`Requires-Python` or the markers associated with the current fork in the
resolver.

Closes #4373
@BurntSushi BurntSushi requested a review from zanieb June 18, 2024 13:56
@zanieb
Copy link
Member

zanieb commented Jun 18, 2024

Did you check for how noisy this is?

@BurntSushi
Copy link
Member Author

Did you check for how noisy this is?

I tried locking with the pyproject.toml in #4133, and the result is that about 10% of all TRACE logs correspond to this addition. And that also reflects about 5% of total DEBUG logs. So I'd say this seems fine. It does seem like pretty useful debugging info.

@BurntSushi BurntSushi merged commit 20b44f3 into main Jun 18, 2024
47 checks passed
@BurntSushi BurntSushi deleted the ag/universal-filter-logs branch June 18, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uv add appears to use the wrong python when requires-python, package, and .venv python version conflict
2 participants