Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for wheel installation with different path #4396

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Jun 18, 2024

Regression test for #4391 / #4393

@ThiefMaster
Copy link

ThiefMaster commented Jun 18, 2024

When you say "path" here, do you mean just the wheel's filename or the whole absolute path to it?

I don't think the path where the wheel file is located should matter - pip does not care about it, regardless of location it shows this message:

mypkg is already installed with the same version as the provided wheel. Use --force-reinstall to force an installation of the wheel.

@zanieb
Copy link
Member Author

zanieb commented Jun 18, 2024

I think we're just using the full file path. I can add test coverage for just the name too.

@ThiefMaster
Copy link

FWIW one case where I think using the full path would be weird is when you have a cronjob or similar that downloads a "latest" wheel from some place (GH actions build or similar) to a temporary location, which might be a /tmp/<randomname>/ folder, and then runs uv pip install /tmp/<randomname>/*.whl.

In such a case I think the expected behavior would be to reinstall only if the version changed (or if I provide a switch to force reinstalling)...

@zanieb
Copy link
Member Author

zanieb commented Jun 18, 2024

Here's the mentioned test case #4398

We don't do what you want yet :)

@zanieb zanieb merged commit 549d7df into main Jun 19, 2024
47 checks passed
@zanieb zanieb deleted the zb/same-path branch June 19, 2024 14:39
zanieb added a commit that referenced this pull request Jun 19, 2024
…th (#4398)

As discussed at
#4396 (comment)

This may not be the desired behavior, but let's track it.
ChannyClaus pushed a commit to ChannyClaus/uv that referenced this pull request Jun 20, 2024
…th (astral-sh#4398)

As discussed at
astral-sh#4396 (comment)

This may not be the desired behavior, but let's track it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Internal testing of behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants