Add some text decoration to toolchain CLI #4882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
cli
charliermarsh
commented
Jul 8, 2024
| installation.key() | ||
| "Found existing installation for {}: {}", | ||
| request.cyan(), | ||
| installation.key().green(), |
There was a problem hiding this comment.
I also tried bold for these but it felt too loud.
There was a problem hiding this comment.
Maybe yellow is more subtle.
|
Other inspiration here could be Cargo which bolds + colors the operation rather than the argument:
|
zanieb
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Attempts to make the CLI output a little more consistent with the
pipinterface. I opted to make the Python versions, requests, and filenames blue, and the keys green, but open to opinions on that. (We use blue for filenames elsewhere.)Closes #4813.
Closes #4814.