Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more realistic names in scenario snapshots #978

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Use more realistic names in scenario snapshots #978

merged 1 commit into from
Jan 19, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Jan 18, 2024

This is helpful to make the error messages more realistic and the names are indisputably cuter.

@zanieb zanieb added the testing Internal testing of behavior label Jan 19, 2024
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gasp, that's fun.

Copy link
Member

@konstin konstin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indisputably

Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what I'm reviewing but I love the names.

Comment on lines +55 to +64
CUTE_NAMES = {
"a": "albatross",
"b": "bluebird",
"c": "crow",
"d": "duck",
"e": "eagle",
"f": "flamingo",
"g": "goose",
"h": "heron",
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@zanieb zanieb merged commit 5fe3444 into main Jan 19, 2024
3 checks passed
@zanieb zanieb deleted the zb/names branch January 19, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Internal testing of behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants