Add support for Suite3 option to release into different suites based on python version. #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nuclearsandwich
added a commit
to ros-infrastructure/catkin_pkg
that referenced
this pull request
Dec 3, 2019
This configuration option requires two recent changes in stdeb and ros_release_python: * astraw/stdeb#147 * ros-infrastructure/ros_release_python#33 The option allows a different set of suites to be set for Python 3 releases allowing us to forestall releasing Python2 versions of these packages for platforms where we don't plan to support Python 2.
dirk-thomas
pushed a commit
to ros-infrastructure/catkin_pkg
that referenced
this pull request
Dec 3, 2019
This configuration option requires two recent changes in stdeb and ros_release_python: * astraw/stdeb#147 * ros-infrastructure/ros_release_python#33 The option allows a different set of suites to be set for Python 3 releases allowing us to forestall releasing Python2 versions of these packages for platforms where we don't plan to support Python 2.
In order to specify a default using the conventional format we must also add a special case to the default regexp parser. As noted we set the value to an empty string and the consuming code will check for the empty string and use the value of the suite option instead.
Previously: With both Suite and Suite3 defined, you could not run `--with-python2 true --with-python3 true`. Now you may do so if and only if the values of Suite and Suite3 are identical.
|
Thanks for the contribution and iterating on it. After reviewing the patch I am fairly confident it will work as desired. Also as long as the new option |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new optional configuration field to stdeb.cfg:
Suite3.The Suite3 field contains an alternative distname value which is used when building with python3 only.
If the field is not present, python3 builds will use the Suite value or its default.
If a Suite3 field is present, running stdeb with both python2 and python3 will raise a ValueError since only one distname can be used.
The ROS team is hoping to use this feature to avoid releasing python2 variants of our packages onto newer Ubuntu versions where Python 2 support is not planned. It has been tested locally using this example config https://github.com/nuclearsandwich/bloom/blob/example-suite3/stdeb.cfg