-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial attempt at GitHub Actions based CI. #199
Open
nuclearsandwich
wants to merge
6
commits into
master
Choose a base branch
from
actions-ci
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're green! (with lowered standards). I am going to take a shot at updating the Vagrantfiles alongside the addition of earthly but I'm tempted to go ahead with this even if it only contributes to my own maintenance of this package. |
9d38ccc
to
febd590
Compare
<https://earthly.dev> is an open source (MPL-2.0) project for defining and executing builds using containers. It meets a lot of the same needs as the Vagrant boxes that are in this project using containers rather than VMs. The advantage of pairing this with GitHub Actions is that it allows maintainers and contributors to reproduce test results locally which is very difficult when using GitHub Actions natively. stdeb interacts with a lot of system-level utilities so having convenient testing across multiple supported distributions is highly valuable.
Since we have the earthly configuration for local testing, we may as well use it for GitHub Actions as well. Use the matrix support to pass the OS build argument to Earthly. Keep platforms that aren't working yet disabled.
* Use python3 for running packaging tests. * Update version of psycopg2 used for tests. I got build failures on bullseye with the earlier version but success with this last one (the psycopg project apparently returned to the psycopg module for v3).
Right now this only sets a preferred line-length limit. It's possible this will be folded into a pyproject.toml as part of other updates to the project.
2a39f87
to
cf542af
Compare
Travis CI has long since stopped providing value to open source projects and I believe that the Earthly builds cover the same local testing niche as the Vagrant files, which I was not able to successful update. If another maintainer or contributor wants to restore the Vagrant support I will help as I can, but I don't have a working vagrant provider locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis has long since ceased being a viable CI platform for open source projects.
It's a pain to bake so heavily into yet another platform but at least it is right here.
I've had some success in other projects using https://earthly.dev to allow the same config to run locally and in CI so wrapping that in GitHub actions may lower the barrier to local testing for future contributors. For now I just want some CI feedback.
The use of
ruff
instead offlake8
is entirely a curiosity since I haven't used before and I'm not at all committed to it.