custom precompile capabilities #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mycodecrafting
requested review from
bharath-123,
joroshiba and
noot
and removed request for
joroshiba and
noot
joroshiba
reviewed
Jul 25, 2024
|
|
||
| 4. Implement the precompile in Go at `./contracts/<precompile>/<precompile.go>`. | ||
| - The struct should implement the `StatefulPrecompiledContract` interface | ||
| - You must methods defined in the Solidity interface |
There was a problem hiding this comment.
I think there is a missing word here
| caller common.Address, | ||
| value *uint256.Int, | ||
| suppliedGas uint64, | ||
| readOnly bool, |
There was a problem hiding this comment.
what is the instance in which this would be true?
There was a problem hiding this comment.
why do we need the .gitignore here?
|
|
||
| // return precompiles that are enabled at height | ||
| func PrecompileConfig(chainConfig *params.ChainConfig, height uint64, timestamp uint64) precompile.PrecompileMap { | ||
| return NullPrecompiles |
There was a problem hiding this comment.
should we add a commented out line of code here on what enabling would look like?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a precompile manager that makes it easy to add new precompiles to the evm by writing an implementation in go which corresponds to a defined solidity interface. These precompiles can optionally have state in the evm state db.
Background
This updates a PR from the old astria
go-ethereumrepo to the latest changes in the newerastria-gethrepo.The precompile manager is heavily utilized by Forma and potentially useful for other custom evm rollups. @itamarreif may have some ideas of things he might like to do with it.
There are no custom precompiles enabled by default.
Changes from old PR