Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conductor: queue for block ordering and execution #15

Closed
noot opened this issue May 2, 2023 · 5 comments
Closed

conductor: queue for block ordering and execution #15

noot opened this issue May 2, 2023 · 5 comments
Assignees
@sambukowski
Labels
conductor pertaining to the astria-conductor crate enhancement New feature or request refactor code refactoring or maintainence
Milestone
MS-4

Comments

@noot
Copy link
Collaborator

noot commented May 2, 2023

we need to execute blocks in order, without any gaps. however, this is not guaranteed by the current implementation.

we should implement some sort of queue that ensures blocks are executed in the correct sequence, and a block cannot be executed without its parent being the current head.
@joroshiba
Copy link
Member

Related: #13

@joroshiba joroshiba transferred this issue from astriaorg/astria-conductor May 18, 2023
@noot noot added enhancement New feature or request conductor pertaining to the astria-conductor crate labels May 23, 2023
@noot noot self-assigned this May 30, 2023
@noot noot removed their assignment Jun 30, 2023
@noot noot changed the title queue for block ordering and execution conductor: queue for block ordering and execution Jul 13, 2023
@noot noot mentioned this issue Jul 18, 2023
Merged
@sambukowski sambukowski self-assigned this Jul 24, 2023
@joroshiba joroshiba mentioned this issue Jul 31, 2023
Closed
@joroshiba joroshiba added this to the MS-4 milestone Jul 31, 2023
@sambukowski sambukowski added the refactor code refactoring or maintainence label Aug 9, 2023
This was referenced Aug 15, 2023
Closed
Closed
@sambukowski
Copy link
Contributor

see pr #284

@emhane
Copy link
Contributor

emhane commented Sep 19, 2023 •
edited
Loading

#332 makes issue obsolete since over (secure #391) websocket blocks are guaranteed to come in sequential order, unlike over a p2p gossip without guarantees of the order of arrival.

@emhane emhane closed this as completed Sep 19, 2023
@joroshiba
Copy link
Member

secure websocket does not fully solve issue, we need lower level prevention of out of order execution for exceptional cases.

@joroshiba joroshiba reopened this Oct 20, 2023
@joroshiba joroshiba mentioned this issue Oct 20, 2023
Closed
@noot
Copy link
Collaborator Author

noot commented Feb 1, 2024

closing as duplicate/stale of #475 and #471 and #464

@noot noot closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sambukowski sambukowski

Labels
conductor pertaining to the astria-conductor crate enhancement New feature or request refactor code refactoring or maintainence
Projects
None yet
Milestone
MS-4
Development

Successfully merging a pull request may close this issue.

conductor: add block queue to executor (v2) astriaorg/astria
4 participants
@joroshiba @sambukowski @noot @emhane