Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for edge cases around soft commitments #13

Closed
joroshiba opened this issue May 18, 2023 · 2 comments · Fixed by #43
Closed

Add support for edge cases around soft commitments #13

joroshiba opened this issue May 18, 2023 · 2 comments · Fixed by #43
Assignees
@noot
Labels
conductor pertaining to the astria-conductor crate

Comments

@joroshiba
Copy link
Member

Currently in conductor, soft commits (gossiped) transactions are executed (via DoBlock) and firm commits (from DA) are finalized (FinalizeBlock).

We need support for various edge cases where transactions aren't seen immediately:

  • gossip not working, transactions seen first in DA
  • missed astria block via gossip (ie block number 10 received but 9 is not)
@joroshiba joroshiba mentioned this issue May 18, 2023
Closed
@noot
Copy link
Collaborator

noot commented May 19, 2023

aren't those two cases the same? ie. the block was received from DA before gossip?

@noot noot self-assigned this May 22, 2023
@joroshiba
Copy link
Member Author

Related but not fully the same.

Both are blocks not received over gossip, but one is a flaky gossip vs fully borked. We could fully solve fully broken, while flaky is still incorrect.

@noot noot added the conductor pertaining to the astria-conductor crate label May 23, 2023
@noot noot mentioned this issue May 26, 2023
Merged
@noot noot closed this as completed in #43 Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noot noot

Labels
conductor pertaining to the astria-conductor crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(conductor): handle case where block is received from DA before gossip astriaorg/astria
2 participants
@joroshiba @noot