transition to single astria-proto directory #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joroshiba
force-pushed
the
astria-proto
branch
2 times, most recently
from
d64defa
to
a99b9b8
Compare
SuperFluffy
reviewed
May 19, 2023
There was a problem hiding this comment.
This looks very good to me.
I would like to match the rust module names to the proto package names (see the comments).
But I am also wondering if the directory structure could be flattened:
# protobuf package
astria.execution.v1
# current path
proto/astria/execution/v1/execution.proto
# suggested path
proto/astria.execution.v1/execution.proto
SuperFluffy
reviewed
May 19, 2023
SuperFluffy
approved these changes
May 19, 2023
There was a problem hiding this comment.
Looks great, thank you for transitioning this.
I would like to merge this into main after #6 is merged.
SuperFluffy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buf.build/astria/astria(non main pushes are drafts)astria-execution-apis-rpcandastria-sequencer-relayer-protointoastria-protoastriafollowing proto standards to allow cleaner imports. (ieastria.execution.v1)astria-sequencer-relayer-protoFixes #10