-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transition to single astria-proto directory #7
Conversation
d64defa
to
a99b9b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good to me.
I would like to match the rust module names to the proto package names (see the comments).
But I am also wondering if the directory structure could be flattened:
# protobuf package
astria.execution.v1
# current path
proto/astria/execution/v1/execution.proto
# suggested path
proto/astria.execution.v1/execution.proto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you for transitioning this.
I would like to merge this into main
after #6 is merged.
buf.build/astria/astria
(non main pushes are drafts)astria-execution-apis-rpc
andastria-sequencer-relayer-proto
intoastria-proto
astria
following proto standards to allow cleaner imports. (ieastria.execution.v1
)astria-sequencer-relayer-proto
Fixes #10