Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bridge-withdrawer): don't panic on init #1281

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix(bridge-withdrawer): don't panic on init #1281

merged 1 commit into from
Jul 19, 2024

Conversation

itamarreif
Copy link
Contributor

Summary

Handle errors from constructing the service and emit an error.

Background

The service was set up to panic instead of emitting an error code and and message if initialization failed.

Changes

  • Handle errors returned by service init rather than panicking and emit an event.

Related Issues

closes #1278

@itamarreif itamarreif added the bridge-withdrawer code touching the bridge-withdrawer service label Jul 19, 2024
@itamarreif itamarreif self-assigned this Jul 19, 2024
@itamarreif itamarreif force-pushed the itamarreif/bridge-withdrawer/initerror branch from c46edf5 to cc40919 Compare July 19, 2024 09:16
@itamarreif itamarreif marked this pull request as ready for review July 19, 2024 09:16
@itamarreif itamarreif requested a review from a team as a code owner July 19, 2024 09:16
SuperFluffy
SuperFluffy approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@SuperFluffy SuperFluffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@itamarreif itamarreif added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit a6d3d96 Jul 19, 2024
42 checks passed
@itamarreif itamarreif deleted the itamarreif/bridge-withdrawer/initerror branch July 19, 2024 10:14
steezeburger added a commit that referenced this pull request Jul 24, 2024
@steezeburger
Merge branch 'main' into feature/ibc-e2e-smoke-test
d62bdde 
* main:
  feat(charts)!: refactor of evm chart (#995)
  feat(composer)!: Add chain_id check on executor build (#1175)
  fix(bridge-withdrawer): don't panic on init (#1281)
bharath-123 pushed a commit that referenced this pull request Jul 25, 2024
@itamarreif @bharath-123
fix(bridge-withdrawer): don't panic on init (#1281)
42fe8c2 
## Summary
Handle errors from constructing the service and emit an error.

## Background
The service was set up to panic instead of emitting an error code and
and message if initialization failed.

## Changes
- Handle errors returned by service init rather than panicking and emit
an event.

## Related Issues
closes [#1278](#1278)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperFluffy SuperFluffy SuperFluffy approved these changes

@Fraser999 Fraser999 Awaiting requested review from Fraser999 Fraser999 is a code owner automatically assigned from astriaorg/rust-reviewers

Assignees

@itamarreif itamarreif

Labels
bridge-withdrawer code touching the bridge-withdrawer service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Service panics if it cannot initialize
2 participants
@itamarreif @SuperFluffy