Generic source-to-disc flux #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjebaker
added
enhancement
Codecov Report
@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 59.46% 61.18% +1.71%
==========================================
Files 37 38 +1
Lines 1083 1149 +66
==========================================
+ Hits 644 703 +59
- Misses 439 446 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fjebaker
added a commit
that referenced
this pull request
Aug 22, 2023
* julia formatting * bugfixes in tetrad + new basis function * formatting and clean * LNRF test Also removed Dilaton-Axion from tests (see issue #52). * lnrf tests and correct domain * use correct analytic expressions * divide flux by time * energy bin size * allow type to be inferred * switch default solver + inference * revert to Tsit5 since other default too noisy * slightly altered api * update exports * fix tetrad tests * voronoi disc profile stores geodesic points as well * julia formatting * source-to-disc flux model * formatting * bump version * typo fixes, includes, and exports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a model for calculating source to disc (reflected) flux for stationary lamp-posts that is metric generic, based off of the tetrad formalism from the previous commits.
It's worth noting that there are analytic LNR frames and bases that can be written in terms of the metric and inverse metric components analytically for stationary, axis-symmetric spacetimes, which will probably outperform the Gram-Schmidt algorithm I've written. These should seriously be added should this line become performance critical! I've left them out for now because I quite like the Gram-Schmidt process, and invested time getting it to work 👍
Once the isotropic angle mapping for other metrics is done (PR soon hopefully), then the 2d-transfer function calculations should be ready to work with any of our metrics!