Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix l1 norm eval #254

Merged

Conversation

Luke-Pratley
Copy link
Collaborator

Fixing an issue with template matching and eigen when evalulating sopt::l1_norm.

Also ensuring that the operator norms can be passed to the algos directly

@codecov-io
Copy link

codecov-io commented Nov 5, 2019

Codecov Report

Merging #254 into development will increase coverage by 0.08%.
The diff coverage is 94.11%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #254      +/-   ##
===============================================
+ Coverage        95.45%   95.53%   +0.08%     
===============================================
  Files               66       66              
  Lines             3671     3670       -1     
===============================================
+ Hits              3504     3506       +2     
+ Misses             167      164       -3
Impacted Files Coverage Δ
cpp/sopt/imaging_forward_backward.h 75% <ø> (ø) ⬆️
cpp/sopt/power_method.h 97.26% <ø> (ø) ⬆️
cpp/sopt/imaging_padmm.h 88.46% <0%> (ø) ⬆️
cpp/tests/primal_dual.cc 100% <100%> (ø) ⬆️
cpp/sopt/l1_proximal.h 95.65% <100%> (+0.03%) ⬆️
cpp/sopt/proximal.h 100% <100%> (ø) ⬆️
cpp/tests/wavelets.cc 99.52% <100%> (+0.01%) ⬆️
cpp/sopt/imaging_primal_dual.h 95.57% <100%> (+0.74%) ⬆️
cpp/sopt/padmm.h 95.83% <100%> (ø) ⬆️
cpp/sopt/forward_backward.h 89.83% <100%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9ab56a...655a2d8. Read the comment docs.

@Luke-Pratley Luke-Pratley merged commit 1ce136c into astro-informatics:development Nov 11, 2019
@Luke-Pratley Luke-Pratley deleted the fix_l1_norm_eval branch November 11, 2019 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants