-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON as an alternative output format #14
Comments
Fine by me |
Just wondering, why is this an optional feature not enabled by default unless you compile from source manually? I would like to add it to my NixOS configuration to use with I'd like to know if there is a way to add this feature flag by overriding |
Since this feature is not required for the core functionality and needs additional dependencies, I disabled it by default in the PR. If it helps, this is how I am currently using it:
|
nixpkgs needs a deadnix version bump anyway. Should we enable the feature by default when using deadnix from nixpkgs? |
Even if I used the code and it worked, but it just seems a little inconvenient because |
To be clear, I would also prefer it being enabled by default in Nixpkgs. What I meant was, I didn't want to change the default behaviour myself. I think that decision should be made by Astro. |
@ilkecan I don't have a strong opinion on this myself, so let's enable the feature by default. @water-sucks I'd love to add LSP functionality one day. On the other hand, editors talk to one LSP server only, right? Then it would make sense to integrate this with rnix-lsp. |
The built-in Neovim LSP client can talk with multiple servers at the same time and this seems to also be the case for some other clients: |
Depends on the editor in question. In Neovim you definitely can attach multiple language servers to a buffer; that's the way I can try adding LSP capability to |
it would be good if deadnix was always compiled with this.. |
@Artturin That is the case since 9617e4c I have released 0.1.5 which is merged in nixpkgs. |
Hi. How would you feel about adding an alternative output format that is easier to parse (like JSON)? I am interested in this to integrate
deadnix
into my editor using null-ls.vim. Would you accept such a PR?The text was updated successfully, but these errors were encountered: