Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using ci-helpers for CI #18

Merged
merged 2 commits into from Jun 17, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 0 additions & 14 deletions .continuous-integration/README.md

This file was deleted.

71 changes: 0 additions & 71 deletions .continuous-integration/appveyor/install-miniconda.ps1

This file was deleted.

47 changes: 0 additions & 47 deletions .continuous-integration/appveyor/windows_sdk.cmd

This file was deleted.

9 changes: 0 additions & 9 deletions .continuous-integration/travis/setup_environment_linux.sh

This file was deleted.

8 changes: 0 additions & 8 deletions .continuous-integration/travis/setup_environment_osx.sh

This file was deleted.

20 changes: 9 additions & 11 deletions .travis.yml
Expand Up @@ -5,21 +5,19 @@ env:
- PYTHON_VERSION=2.7 UNITPKG=false
- PYTHON_VERSION=3.3 UNITPKG=false
- PYTHON_VERSION=3.4 UNITPKG=false
- PYTHON_VERSION=3.5 UNITPKG=false
- PYTHON_VERSION=2.7 UNITPKG=true
- PYTHON_VERSION=3.3 UNITPKG=true
- PYTHON_VERSION=3.4 UNITPKG=true

before_install:
- source .continuous-integration/travis/setup_environment_$TRAVIS_OS_NAME.sh
- conda create --yes -n test python=$PYTHON_VERSION
- source activate test
- PYTHON_VERSION=3.5 UNITPKG=true
global:
- CONDA_DEPENDENCIES="pytest numpy"
- PIP_DEPENDENCIES="coveralls pytest-cov traitlets"

install:
- conda install --yes pip pytest numpy
- pip install coveralls pytest-cov traitlets
- if [[ $UNITPKG == true ]]; then conda install --yes astropy; fi
- if [[ $UNITPKG == true ]]; then pip install quantities pint; fi
- if [[ $PYTHON_VERSION == 2.6 ]]; then conda install --yes unittest2; fi
- if [[ $UNITPKG == true ]]; then export CONDA_DEPENDENCIES="astropy "$CONDA_DEPENDENCIES; fi
- if [[ $UNITPKG == true ]]; then export PIP_DEPENDENCIES="quantities pint "$PIP_DEPENDENCIES; fi
- git clone git://github.com/astropy/ci-helpers.git
- source ci-helpers/travis/setup_conda_$TRAVIS_OS_NAME.sh

script:
- py.test --cov numtraits.py
Expand Down
6 changes: 3 additions & 3 deletions numtraits.py
Expand Up @@ -182,7 +182,7 @@ def identify_unit_framework(target_unit):

from pint.unit import UnitsContainer

if hasattr(target_unit, 'units') and isinstance(target_unit.units, UnitsContainer):
if hasattr(target_unit, 'dimensionality') and isinstance(target_unit.dimensionality, UnitsContainer):

return PINT

Expand Down Expand Up @@ -231,11 +231,11 @@ def assert_unit_convertability(name, value, target_unit, unit_framework):

from pint.unit import UnitsContainer

if not (hasattr(value, 'units') and isinstance(value.units, UnitsContainer)):
if not (hasattr(value, 'dimensionality') and isinstance(value.dimensionality, UnitsContainer)):
raise TraitError("{0} should be given as a Pint Quantity instance".format(name))

if value.dimensionality != target_unit.dimensionality:
raise TraitError("{0} should be in units convertible to {1}".format(name, target_unit.units))
raise TraitError("{0} should be in units convertible to {1}".format(name, target_unit))

elif unit_framework == QUANTITIES:

Expand Down