Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch keyboard interrupt + misc minor improvements #8

Closed
wants to merge 4 commits into from

Conversation

saimn
Copy link
Contributor

@saimn saimn commented Jun 9, 2014

Hi Thomas,

This PR contains some improvements and a bugfix for psutil 2.0 which changed its API:

  • Catch keyboard interrupt to clean up things: close the log file, draw the plot, kill the process if needed.
  • Process status is now a method (changed with psutil 2.0). + Print elapsed time.
  • Allow to use a float interval.
  • Pep8

@astrofrog
Copy link
Owner

@saimn - thanks for this! I'm going to merge the commits manually in pieces since I want to make a couple of changes.

@astrofrog
Copy link
Owner

I've opened new PRs for the 713b4db and 6beb56e changes. For the keyboard interrupt, I want to try and find a better way to do it rather than have a whole chunk of code inside a try...except - I think I know how to do it, but will try in a separate PR. And for 24da315 I applied the same change independently. Thanks for the fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants