Optimization is dangerous because if transforms changed the transform…

…ation should not be skipped. Instead, avoid recomputing axes patch every time a grid line is added.

wcsaxes/coordinate_helpers.py

@@ -343,9 +343,10 @@ def _draw(self, renderer, bboxes, ticklabels_bbox):
 
             if self._grid_type == 'lines':
 
+                frame_patch = self.frame.patch
                 for path in self.grid_lines:
                     p = PathPatch(path, **self.grid_lines_kwargs)
-                    p.set_clip_path(self.frame.patch)
+                    p.set_clip_path(frame_patch)
                     p.draw(renderer)
 
             else:

wcsaxes/frame.py

@@ -28,8 +28,6 @@ def data(self, value):
             self._pixel = None
             self._world = None
         else:
-            if np.all(value == self._data):
-                return  # no need to reset and recompute
             self._data = value
             self._pixel = self.parent_axes.transData.transform(self._data)
             self._world = self.transform.transform(self._data)
@@ -46,8 +44,6 @@ def pixel(self, value):
             self._pixel = None
             self._world = None
         else:
-            if np.all(value == self._pixel):
-                return  # no need to reset and recompute
             self._data = self.parent_axes.transData.inverted().transform(self._data)
             self._pixel = value
             self._world = self.transform.transform(self._data)
@@ -64,8 +60,6 @@ def world(self, value):
             self._pixel = None
             self._world = None
         else:
-            if np.all(value == self._world):
-                return  # no need to reset and recompute
             self._data = self.transform.transform(value)
             self._pixel = self.parent_axes.transData.transform(self._data)
             self._world = value