-
Notifications
You must be signed in to change notification settings - Fork 21
Fixing miniconda path in .travis.xml and updating helpers #180
Fixing miniconda path in .travis.xml and updating helpers #180
Conversation
18167c1
to
fa3d066
Compare
@astrofrog - Do you want to use |
@bsipocz - yes, that would be great, thanks! |
env: | ||
global: | ||
# The following versions are the 'default' for tests, unless | ||
# overidden underneath. They are defined here in order to save having | ||
# to repeat them for all configurations. | ||
- NUMPY_VERSION=1.9 | ||
- NUMPY_VERSION=1.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsipocz - can you change this to stable
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure.
On 18 January 2016 at 14:21, Thomas Robitaille notifications@github.com
wrote:
In .travis.yml
#180 (comment):env:
global:
# The following versions are the 'default' for tests, unless
# overidden underneath. They are defined here in order to save having
# to repeat them for all configurations.
- NUMPY_VERSION=1.9
- NUMPY_VERSION=1.10
@bsipocz https://github.com/bsipocz - can you change this to stable?
—
Reply to this email directly or view it on GitHub
https://github.com/astrofrog/wcsaxes/pull/180/files#r50003030.
Some of the tests fail with the OrderedDict issue, and many fail with |
@bsipocz - yes, that might make sense for now. I can look at the pytest-mpl issues today. Can you update the |
It's already in #184 |
Do you want appveyor, too? |
@bsipocz - I'm not sure if the image testing will work on Windows, so maybe we can do that in another PR once one of us has time |
Ohh, sure, I've already forgot about the image testing issues. That case it should be definitely a new PR. |
68dd780
to
9bcd50c
Compare
@astrofrog - now I've rebased this on #184, so it should pass and be ready for review. |
@bsipocz - I think the remaining issue is because you need to change the language to c and set |
@astrofrog - Could you please restart that build? It didn't fail before, and the last commit didn't touch any 3.5 related stuff so I think it's very probably just a random fail. |
try: | ||
from ordereddict import OrderedDict | ||
except ImportError: | ||
OrderedDict = dict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can actually just remove Python 2.6 support and include only the import from collections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, sounds good.
4eafb2a
to
1131d89
Compare
Thank you very much @bsipocz! :) |
Fixing miniconda path in .travis.xml and updating helpers
Fixing miniconda path in .travis.xml and updating helpers
Miniconda's default prefix changed recently causing all travis builds failing.
And while I was at it I've updated the helpers to the latest one.