Skip to content
This repository has been archived by the owner on Jun 16, 2018. It is now read-only.

Fixing miniconda path in .travis.xml and updating helpers #180

Merged
merged 11 commits into from
Jan 18, 2016

Conversation

bsipocz
Copy link
Contributor

@bsipocz bsipocz commented Nov 4, 2015

Miniconda's default prefix changed recently causing all travis builds failing.

And while I was at it I've updated the helpers to the latest one.

@bsipocz
Copy link
Contributor Author

bsipocz commented Jan 18, 2016

@astrofrog - Do you want to use ci-helpers here, too? If yes I can update this PR.

@astrofrog
Copy link
Owner

@bsipocz - yes, that would be great, thanks!

env:
global:
# The following versions are the 'default' for tests, unless
# overidden underneath. They are defined here in order to save having
# to repeat them for all configurations.
- NUMPY_VERSION=1.9
- NUMPY_VERSION=1.10
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsipocz - can you change this to stable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure.

On 18 January 2016 at 14:21, Thomas Robitaille notifications@github.com
wrote:

In .travis.yml
#180 (comment):

env:
global:
# The following versions are the 'default' for tests, unless
# overidden underneath. They are defined here in order to save having
# to repeat them for all configurations.

  •    - NUMPY_VERSION=1.9
    
  •    - NUMPY_VERSION=1.10
    

@bsipocz https://github.com/bsipocz - can you change this to stable?


Reply to this email directly or view it on GitHub
https://github.com/astrofrog/wcsaxes/pull/180/files#r50003030.

@bsipocz
Copy link
Contributor Author

bsipocz commented Jan 18, 2016

Some of the tests fail with the OrderedDict issue, and many fail with pytest-mpl. I guess we should fix mpl version to 1.4.3 to get them pass?

@astrofrog
Copy link
Owner

@bsipocz - yes, that might make sense for now. I can look at the pytest-mpl issues today. Can you update the OrderedDict imports?

@bsipocz
Copy link
Contributor Author

bsipocz commented Jan 18, 2016

It's already in #184

@bsipocz
Copy link
Contributor Author

bsipocz commented Jan 18, 2016

Do you want appveyor, too?

@astrofrog
Copy link
Owner

@bsipocz - I'm not sure if the image testing will work on Windows, so maybe we can do that in another PR once one of us has time

@bsipocz
Copy link
Contributor Author

bsipocz commented Jan 18, 2016

Ohh, sure, I've already forgot about the image testing issues. That case it should be definitely a new PR.

@bsipocz
Copy link
Contributor Author

bsipocz commented Jan 18, 2016

@astrofrog - now I've rebased this on #184, so it should pass and be ready for review.

@astrofrog
Copy link
Owner

@bsipocz - I think the remaining issue is because you need to change the language to c and set PYTHON_VERSION manually (like we do in the core package). Otherwise it tries to get a built-in 3.5, which doesn't seem to work.

@bsipocz
Copy link
Contributor Author

bsipocz commented Jan 18, 2016

@astrofrog - Could you please restart that build? It didn't fail before, and the last commit didn't touch any 3.5 related stuff so I think it's very probably just a random fail.

try:
from ordereddict import OrderedDict
except ImportError:
OrderedDict = dict
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can actually just remove Python 2.6 support and include only the import from collections

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sounds good.

@astrofrog
Copy link
Owner

Thank you very much @bsipocz! :)

astrofrog added a commit that referenced this pull request Jan 18, 2016
Fixing miniconda path in .travis.xml and updating helpers
@astrofrog astrofrog merged commit e31b247 into astrofrog:master Jan 18, 2016
astrofrog added a commit that referenced this pull request Nov 28, 2016
Fixing miniconda path in .travis.xml and updating helpers
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants