Skip to content
This repository has been archived by the owner on Jun 16, 2018. It is now read-only.

Plotting 'real' circles in celestial coordinates #199

Merged
merged 5 commits into from
May 11, 2016
Merged

Conversation

astrofrog
Copy link
Owner

@astrofrog astrofrog commented May 10, 2016

This PR is an attempt to address issues such as #185. I did two separate things:

  • I added a new SphericalCircle patch class that can be used to plot true cicles in spherical coordinates - where by true I mean that they are the collection of points within a certain angle of a fixed point. Note that these can still look distorted in images due to the spherical projection, or distortion terms in the headers.
  • I rewrote the documentation on overlays to make it clearer that if the user simply wants to highlight points, then using something like ax.scatter is a better choice, because only the center of the circle gets transformed, but the marker will always be shown as a circle in the frame of the plot. I also then illustrated the issue with patches and showed how to use SphericalCircle

@hamogu - since you are familiar with this issue, having reported #185, could you review this? A build of the new docs is available here: http://wcsaxes.readthedocs.io/en/spherical-patches/overlays.html - please let me know if I can make this clearer anywhere!


The following example shows how to get the transformation object for the FK5
coordinate system::
For example, in the following example, the scatter markers and the rectangle
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

word "example" appears twice in one line.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@hamogu
Copy link

hamogu commented May 10, 2016

Review done.

@astrofrog
Copy link
Owner Author

@hamogu - thanks for the review! :)

@astrofrog astrofrog merged commit 3348bb6 into master May 11, 2016
astrofrog added a commit that referenced this pull request Nov 28, 2016
Plotting 'real' circles in celestial coordinates
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants