This repository has been archived by the owner on Jun 16, 2018. It is now read-only.
Inherit default grid and tick style from matplotlib.rcParams
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on `matplotlib.axis.YTick._get_gridline`. Note that Matplotlib implements gridlines with `Line2D`, whereas wcsaxes implements gridlines with `PathPatch`. The two have slightly different option styles regarding dashes, so we have to map between them.
Note that Matplotlib's defaults dictionary contains default settings only for `xtick.*` and `ytick.*`. Because there is not a fixed mapping between WCS axes and Matplotlib `x` and `y` axes, the best we can do is arbitrarily pick one axis from which to inherit defaults. This is explained in the docstring.
And update original unit tests to explicitly set tick width and size, overriding default values, so that they continue to pass.
|
@lpsinger - thanks! I think it would be good to add the same for tick label and axis label parameters, but we can add this later. |
astrofrog
added a commit
that referenced
this pull request
Jun 18, 2014
Inherit default grid and tick style from `matplotlib.rcParams`
astrofrog
added a commit
that referenced
this pull request
Nov 28, 2016
Inherit default grid and tick style from `matplotlib.rcParams`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #43 and #44, but adds a unit test.