This repository has been archived by the owner on Jun 16, 2018. It is now read-only.
Non rectangular frames #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anizami - just for information, I added a tweak to what you had implemented before to make it so that minpad can be either a float or a dictionary mapping each axis 'spine' to a different minpad - see the test I'm adding here to understand better. I can explain it tomorrow on the hangout :) |
| else: | ||
| top = ycen | ||
| ypos = top + padding | ||
| self.set_position((xcen, ypos)) |
There was a problem hiding this comment.
@anizami - these are only indentation changes because I added an if clause, to make sure it works for non-rectangular axes (below).
There was a problem hiding this comment.
@astrofrog - Ahh okay. These non-rectangular frames are interesting..
…allow arbitrary frame class to be specified. Finally, use the frame class to define the axis patch.
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements non-rectangular frames: