Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AD filter returns a Pandas DataFrame #145

Merged
merged 3 commits into from May 22, 2023
Merged

AD filter returns a Pandas DataFrame #145

merged 3 commits into from May 22, 2023

Conversation

JulienPeloton
Copy link
Member

IMPORTANT: Please create an issue first before opening a Pull Request.
Linked to issue(s): Closes #144

What changes were proposed in this pull request?

The filter returns a Pandas DataFrame instead of a Spark DataFrame (more convenient for database operations later, as it avoids a toPandas to be performed).

The test suite has been extended as well.

How was this patch tested?

Manually + CI

@JulienPeloton JulienPeloton changed the title Issue/144/ad AD filter returns a Pandas DataFrame May 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +4.20 🎉

Comparison is base (d263622) 63.28% compared to head (1549a66) 67.49%.

❗ Current head 1549a66 differs from pull request most recent head 7c0c0b0. Consider uploading reports for the commit 7c0c0b0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   63.28%   67.49%   +4.20%     
==========================================
  Files          17       17              
  Lines         523      526       +3     
==========================================
+ Hits          331      355      +24     
+ Misses        192      171      -21     
Impacted Files Coverage Δ
fink_filters/__init__.py 100.00% <100.00%> (ø)
fink_filters/filter_anomaly_notification/filter.py 93.54% <100.00%> (+75.69%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JulienPeloton JulienPeloton merged commit fd66daf into master May 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update anomaly filter output
2 participants