Cutouts + light curves in anomaly notifications #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code is ready for review, but I don't know how to hide the tokens to pass the tests |
JulienPeloton
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Thanks @Knispel2 ! For the tokens, we could use the Slack Fink_bot_test workspace, and the Telegram Fink_test channel? You can send me the token via email, and I will add them in the secrets of GitHub.
| pdf[maskValid & maskFilt]['i:jd'].apply(lambda x: x - 2400000.5), | ||
| pdf[maskValid & maskFilt]['i:magpsf'], | ||
| pdf[maskValid & maskFilt]['i:sigmapsf'], | ||
| ls='', marker='o', color=colordic[filt] |
There was a problem hiding this comment.
I would also add the label=filt argument
| ls='', marker='v', color=colordic[filt] | ||
| ) | ||
|
|
||
| plt.gca().invert_yaxis() |
There was a problem hiding this comment.
I would add the plt.legend() command to display the legend.
JulienPeloton
merged commit 1c81737
into
astrolabsoftware:ad_secrets
2 of 4 checks passed
1 task
JulienPeloton
added a commit
that referenced
this pull request
Jul 17, 2023
* Cutouts + light curves in anomaly notifications (#153) * ZTF DR OID added * docstring * docstring refinement * flake8 check * ZTF DR OID ---> DR OID (<1'') * '' -> " * Moving the variables inside the if * cutouts+lc images in notifications * Hide token in status_check * Add secrets to the env * plot legend * correction --------- Co-authored-by: Timofei Pshenichnyy <93309519+Knispel2@users.noreply.github.com> Co-authored-by: Timofei Pshenichniy <timofei.psheno@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added 3 new functions:
get_cutout- this function loads cutout image via Fink API;get_curve- this function loads light curve image via Fink API (I used the code from the example in Fink API documentation to build the curve);get_data_permalink_slack- using the two functions listed above, this function loads two images and copies these images to the Slack server.I also put the status_code check of post requests into a separate function
status_check, so as not to duplicate the code.These versions of the modules are required to upload images to Slack:
slack-sdk==3.21.3 or newer
slackclient==2.9.4 or newer
Examples:
