Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the channel ID instead of the test channel #155

Merged
merged 2 commits into from Jul 17, 2023
Merged

Use the channel ID instead of the test channel #155

merged 2 commits into from Jul 17, 2023

Conversation

JulienPeloton
Copy link
Member

@JulienPeloton JulienPeloton commented Jul 17, 2023

Bug fix for release 3.16 (anomaly detection filter)

  • grant correct permission (files:write) for the slack bot
  • understand failure for telegram when sending files

@JulienPeloton JulienPeloton added bug Something isn't working anomaly detection labels Jul 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.11 🎉

Comparison is base (55fb455) 69.54% compared to head (da41acc) 69.65%.

❗ Current head da41acc differs from pull request most recent head 287c79b. Consider uploading reports for the commit 287c79b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   69.54%   69.65%   +0.11%     
==========================================
  Files          17       17              
  Lines         614      613       -1     
==========================================
  Hits          427      427              
+ Misses        187      186       -1     
Impacted Files Coverage Δ
...ilters/filter_anomaly_notification/filter_utils.py 64.77% <ø> (-0.07%) ⬇️
fink_filters/filter_anomaly_notification/filter.py 94.87% <100.00%> (+0.27%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JulienPeloton JulienPeloton merged commit d8bfee2 into master Jul 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
anomaly detection bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants