Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new filter for Blazar and BLLac #165

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Conversation

JulienPeloton
Copy link
Member

IMPORTANT: Please create an issue first before opening a Pull Request.
Linked to issue(s): Closes #164

What changes were proposed in this pull request?

New filter for Blazar and BLLac from SIMBAD (plus candidates).

@JulienPeloton JulienPeloton added new filter Add a new filter blazar labels Dec 15, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (40b3df7) 70.14% compared to head (add0cc2) 70.27%.

❗ Current head add0cc2 differs from pull request most recent head 75c7f0a. Consider uploading reports for the commit 75c7f0a to get more accurate results

Files Patch % Lines
fink_filters/filter_blazar/filter.py 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
+ Coverage   70.14%   70.27%   +0.12%     
==========================================
  Files          18       19       +1     
  Lines         670      683      +13     
==========================================
+ Hits          470      480      +10     
- Misses        200      203       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JulienPeloton JulienPeloton merged commit b8fc8b4 into master Dec 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blazar new filter Add a new filter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter for BL Lac and Blazar from SIMBAD
2 participants